On Thu, 17 Aug 2006, Lonnie Mendez wrote:

>
>> diff -uprN -X baseline/Documentation/dontdiff 
>> baseline/drivers/usb/serial/cypress_m8.c p1/drivers/usb/serial/cypress_m8.c
>> --- baseline/drivers/usb/serial/cypress_m8.c 2006-07-15 14:00:43.000000000 
>> -0500
>> +++ p1/drivers/usb/serial/cypress_m8.c       2006-08-16 22:16:37.000000000 
>> -0500
>> @@ -74,7 +74,7 @@
>>      static int debug;
>>   #endif
>>   static int stats;
>> -static int interval;
>> +static int interval = 0;
>
> This is redundant.  A static variable will be initialized as 0 on
> creation.
>

Sorry, this is a habit for me.  In cases where a global (or static) 
value's initial value is truly important I've always explicitly 
initialized it.  Of course it's default value is zero, but with the 
explicit initialization there's still no cost in code size or performance, 
and the presence of the value becomes a hint to the developer that the 
initial value is important.  I would not have made this change purely for 
the sake of making it, but it was just an unconscious part of the larger 
changes made so that interval is noticed and used at the appropriate 
point.

But whatever.

   -Mike


-- 
                         |         Mike Isely          |     PGP fingerprint
      Spammers Die!!     |                             | 03 54 43 4D 75 E5 CC 92
                         |   isely @ pobox (dot) com   | 71 16 01 E2 B5 F5 C1 E8
                         |                             |

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to