On Fri, 18 Aug 2006 12:17:50 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote:
> Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > In this version the code change looks pretty small. Instead of adding a > flag, the test could be encapsulated in an inline routine. Do you think > that would be better? > + hcd->self.uses_dma = (dev->dma_mask != NULL); Naah, I like it as is, primarily because we do not have millions of buses, so memory consumption is not great. But I'm not religous about it. As for usbmon copying ->dma_mask, I might eventually just merge usbmon in the core. When I made them separate, I fantacised about someone creating a better usbmon (usbmon module), but it's obviously not happening. -- Pete ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
