On Fri, 25 Aug 2006, Per Hallsmark wrote: > Hi all, > > There exists a notifier for reboot, ehci_reboot. > > When I upgraded to linux-2.6.17.8 (on a xscale ixp465) the reboot > function was called upon infinitum when trying to reboot. > I noticed the function returns simply with 0 instead of NOTIFY_OK > or NOTIFY_STOP. Had to use NOTIFY_STOP to make run only > one time. Thereafter the system rebooted nicely as it should :)
That is definitely the wrong thing to do. If you return NOTIFY_STOP then none of the remaining entries on the notifier chain will be called. It's not clear why the function was being called repeatedly. It could be that the notifier chain itself had gotten corrupted somehow. You might want to check that. The relevant subroutines to debug are all in kernel/sys.c. > Have seen a patch floating around where the calls to register/unregister > the callback is done differently, but shouldn't the function also return a > valid value instead of 0? > (NOTIFY_OK is 1 and NOTIFY_STOP is 0x8001) It doesn't make any difference whether you return NOTIFY_OK or 0. Only the NOTIFY_STOP_MASK bit in the return value is checked. Alan Stern ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
