On Sunday 20 August 2006 1:07 pm, Arnd Bergmann wrote: > This driver adds support for the DeLOCK USB ethernet adapter > and potentially others based on the MosChip MCS7830 chip. > > It is based on the usbnet and asix drivers as well as the > original device driver provided by MosChip, which in turn > was based on the usbnet driver. > > It has been tested successfully on an OHCI, but interestingly > there seems to be a problem with the mcs7830 when connected to > the ICH6/EHCI in my thinkpad: it keeps receiving lots of > broken packets in the RX interrupt.
That is, the "status" polling which you disabled?? If so, please update this comment ... > The problem goes away when > I'm using an active USB hub, so I assume it's not related to > the device driver, but rather to the hardware. > > Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> Looks basically OK to me, although I'd rather see the two patches you posted on 27-August be merged into it before an upstream merge. (To use normal MII constants, and handle max size frames.) > --- > > This version incorporates a few cleanups from myself an changes > based on comments from David Hollis. He has more experience than I do with respect to these sorts of real Ethernet adapters and usbnet. :) Speaking of which ... isnt this driver missing a hook to make the MII stuff visible through ethtool? - Dave > In particular, it now has > > - an rx_fixup function that removes an out-of-band data byte > from each received packet. > - got rid of the status function, which did not do the right thing > and is not needed in this driver. > - has a working set_multicast function, although that one always > needs to set allmulticast mode in order to get the chip to > receive any frames. > - doesn't use a private mutex in its mii functions, that functionality > is added in a separate patch to usbnet. > > Please merge the driver in 2.6.19! > > drivers/usb/net/Kconfig | 8 > drivers/usb/net/Makefile | 1 > drivers/usb/net/mcs7830.c | 474 > ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 483 insertions(+) > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
