On Thursday 28 September 2006 12:33 am, Christopher "Monty" Montgomery wrote:
> patch 15: This is a usbaudio fixed necessitated by fixing the isoch
> underrun detection/reporting in ehci. usbaudio playback nominally
> causes one harmless underrun in setup that the usbaudio code doesn't
> currently handle correctly.
>
> Signed-off-by: Christopher "Monty" Montgomery <[EMAIL PROTECTED]>
I'll NAK this one on the grounds that this is clearly the wrong
place to try fixing this ... EHCI shouldn't be returning such a
fault code, as the current driver (before any of your patches)
says in the relevant comment.
- Dave
>
> ---
>
> diff -rup a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
> --- a/sound/usb/usbaudio.c 2006-09-27 20:07:34.000000000 -0400
> +++ b/sound/usb/usbaudio.c 2006-09-27 22:48:54.000000000 -0400
> @@ -839,6 +839,9 @@ static int start_urbs(struct snd_usb_sub
> subs->running = 1;
> for (i = 0; i < subs->nurbs; i++) {
> err = usb_submit_urb(subs->dataurb[i].urb, GFP_ATOMIC);
> + if (err == -EL2NSYNC)
> + err = usb_submit_urb(subs->dataurb[i].urb, GFP_ATOMIC);
> +
> if (err < 0) {
> snd_printk(KERN_ERR "cannot submit datapipe "
> "for urb %d, error %d: %s\n",
> @@ -850,6 +853,8 @@ static int start_urbs(struct snd_usb_sub
> if (subs->syncpipe) {
> for (i = 0; i < SYNC_URBS; i++) {
> err = usb_submit_urb(subs->syncurb[i].urb, GFP_ATOMIC);
> + if (err == -EL2NSYNC)
> + err = usb_submit_urb(subs->syncurb[i].urb,
> GFP_ATOMIC);
> if (err < 0) {
> snd_printk(KERN_ERR "cannot submit syncpipe "
> "for urb %d, error %d: %s\n",
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
