On Thu, Oct 19, 2006 at 10:32:39AM -0600, Grant Grundler wrote: > /* > * Extract/implement a data field from/to a little endian report (bit array). > + * > + * Code sort-of follows HID spec: > + * http://www.usb.org/developers/devclass_docs/HID1_11.pdf > + * > + * While the USB HID spec allows unlimited length bit fields in "report > + * descriptors",
To be sligtly pedantic, extract() isn't actually used on report descriptors, but rather report fields. The length of the field is set in the descriptor but the actual data to be extracted lives in the report. So perhaps, "...bit fields in reports..." would be more accurate. > most devices never use more than 16 bits. I disagree with that comment a bit. UPSes routinely have 24 bit wide fields as well. I'd really like to avoid promoting the idea that all HID devices are simple little keyboards and mice and anything else is some weird exception, especially because these exceptions are perfectly standards compliant. I'd compromise on a change from "most" to "many" if you feel strongly about keeping the sentence. > + * One model of UPS is claimed to report "LINEV" as a 32-bit field. I'd prefer to remove the word "claimed" and say instead, "One model of APC UPS reports "LINEV" as a 32-bit field, for example." With the above wording tweaks: Acked-By: Adam Kropelin <[EMAIL PROTECTED]> --Adam ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
