On Wed, 25 Oct 2006, David Brownell wrote: > On Tuesday 24 October 2006 9:05 am, Alan Stern wrote: > > This patch (as808) fixes a minor race in ohci-hcd's root-hub code. If > > we have to turn off the Root-Hub-Status-Change bit in the Interrupt > > Status register, better to do it _before_ looking for status changes > > Patch looks OK, but the point is "disable the RHSC IRQ" ... not > "turn off the RHSC bit in interrrupt status register" (a.k.a. > "ack the RHSC IRQ"), which was already done in the IRQ handler.
Whoops, you're right. I used the wrong word in the patch description. > Plus, when you moved this code from the IRQ handler, it lost the > context: that disabling that IRQ is part of IRQ handling logic, > because of the level/edge triggering choice noted in the comment. > That's no longer clear from the comment ... can you update it? > > Or better yet, just move this block of code back to the IRQ handler, > which is where IMO it really belongs. I moved it here so that the hub_status_data routine could leave polling turned on if the RHSC IRQ is disabled. On second thought that doesn't seem to be necessary, since khubd would be busy and unable to respond to those polls anyway. So yes, I'll move that code back to where it used to be. Greg, expect a revised version of this patch. Alan Stern ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
