On Sun, 29 Oct 2006, Oliver Neukum wrote: > Hi, > > this patch makes hid devices do simple open/close powersave. > This is helpful only in a minority of cases, but it works. Powersave > with timeouts will need this as a foundation. > Alan, I've made use of your suggestion and put the macros into > usb.h so they can be commonly used.
This is a reasonable and simple enough approach. Does it help with things like the fingerprint readers found in IBM laptops? Regarding the patch itself: If you're only going to disable autopm on open and enable on close then you could have used usb_autopm_get_interface() and usb_autopm_put_interface(). Presumably you didn't want to take that approach because it would make things harder for later timeout-based patches? When you add those later patches, don't forget to set intf->needs_remote_wakeup! The usb_autpm_enable/disable things should go in a separate patch. Since you find them useful, I'll add them into the usb_autopm_set_interface patch and submit that on its own. It might be a good idea to make them static inlines rather than macros; it's cleaner that way. Alan Stern P.S.: Did you ever figure out why ksuspend_usbd was using 97% of your CPU time? ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
