On Sun, 2006-11-05 at 12:25 -0500, Alan Stern wrote: > On Sun, 5 Nov 2006, Benjamin Herrenschmidt wrote: > > > Hi ! > > > > I'm sending this patch on behalf of Toshiba. This version of the patch > > is mostly for comments, I'll forward a more "final" one as soon as I get > > it from them, possibly addressing comments you guys might have. > > > > The goal is to have that in 2.6.20 along with the support for the > > platforms that need this (Toshiba Cell based "Celleb" platform, and a > > soon-to-be-released-long-awaited other Cell one I can't talk about right > > now :-) > > > > The issue is that those have an EHCI/OHCI pair which has big endian > > registers but little manipulates DMA data structures in little endian > > form (some would say they are only half broken :-) > > > > The OHCI change is trivial. The EHCI change is more invasive as EHCI > > didn't have any support for big-endian cells so far, but it's also > > pretty much on the trivial side of things, mostly replacing readl/writel > > with ehci_readl/ehci_writel. > > Just so that you know -- I'm in the middle of submitting one or more > patches that do MMIO in ehci-hcd. Once Greg has accepted them you will > have to update your patch to change my patch's readl() and writel() calls > to ehci_readl() and ehci_writel(). No big deal. > > There doesn't seem to be anything objectionable in the patch itself.
As you said, no big deal. Can you send me your patch so I can prepare a new version of the Toshiba one in advance ? Thanks ! Ben. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
