On Mon, 06 Nov 2006 11:26:43 +0100, Paolo Abeni <[EMAIL PROTECTED]> wrote:

> I would like to share my last work to add a binary interface to usbmon.
> This is still quite rough and does use the dreaded next_urb field into
> the urb header structure, so it's not intended as a finished work. 

I still think that next_urb is redundant, because it should be
easy to tell where the next header is from the data size of the
previous header. I haven't looked in great detail yet, so I cannot
be completely sure.

A few details jump at me immediately.
- 4 space tabs (naturally, they add some trailing whitespace as well)
- VMA counters are not locked (I dunno, maybe this is all right?)
- The fetch function dereferences user pointers.

-- Pete

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to