Hello,
> > I could do that in one series of patches. It is simple enough not to break
> > things and
> > hopefuly remove lots of redundant code. What do you thik of these
> > (proposed) changes?
>
> They all sound good.
Huh. This way I spotted this:
drivers/usb/input/ati_remote.c-636- if (ati_remote->inbuf)
drivers/usb/input/ati_remote.c:637:
usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
drivers/usb/input/ati_remote.c-638-
ati_remote->inbuf, ati_remote->inbuf_dma);
drivers/usb/input/ati_remote.c-639-
drivers/usb/input/ati_remote.c-640- if (ati_remote->outbuf)
drivers/usb/input/ati_remote.c:641:
usb_buffer_free(ati_remote->udev, DATA_BUFSIZE,
drivers/usb/input/ati_remote.c-642-
ati_remote->inbuf, ati_remote->outbuf_dma);
This is a bug (possible memleak) because when ati_remote->outbuf != NULL we try
to free ati_remote->inbuf.
Hopefully these patches will shake some more bugs out :-)
--
Regards,
Mariusz Kozlowski
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
