Isn't copy_from_buf supposed to return "an error code, not an offset"? Look at line 232 (return off;). I think it should probably return 0. Addiionally, I don't think that the while loop in mon_bin_read (line 636) is supposed to be negated. I have also merged the patch with 2.6.19-rc6. Most of the upstream change were pretty trivial. I'll post a new patch soon but I'm quite tired at the moment and have to remove some debugging output code that I added before diffing. Thanks,
- Ben On Wed, 2006-11-22 at 14:41 +0100, Marcel Holtmann wrote: > Hi Pete, > > > Here's what I have right now. It pretty much takes shape, only mmap is > > remaining to be done. I'm basically going to copy your code there, only > > change it from 4-space to 1-tab formatting. > > you don't have by any chance a version that applies cleanly against the > latest 2.6.19-rc tree from Linus. I haven't looked at the rejects, but > it seems that some patches have touch the upstream usbmon code. > > Regards > > Marcel > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > linux-usb-devel@lists.sourceforge.net > To unsubscribe, use the last form field at: > https://lists.sourceforge.net/lists/listinfo/linux-usb-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
