On Sat, Dec 02, 2006 at 10:52:56AM -0500, Alan Stern wrote: > On Fri, 1 Dec 2006, Greg KH wrote: > > > From: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > Might speed up some systems. If nothing else, a bad driver should not > > take the whole USB subsystem down with it. > > > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > --- > > drivers/usb/core/Kconfig | 15 ++++++++ > > drivers/usb/core/hub.c | 81 > > +++++++++++++++++++++++++++++++++------------ > > 2 files changed, 74 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig > > index 6e3b535..f8324d8 100644 > > --- a/drivers/usb/core/Kconfig > > +++ b/drivers/usb/core/Kconfig > > @@ -72,6 +72,21 @@ config USB_SUSPEND > > > > If you are unsure about this, say N here. > > > > +config USB_MULTITHREAD_PROBE > > + bool "USB Multi-threaded probe (EXPERIMENTAL)" > > + depends on USB && EXPERIMENTAL > > + default n > > + help > > + Say Y here if you want the USB core to spawn a new thread for > > + every USB device that is probed. This can cause a small speedup > > + in boot times on systems with a lot of different USB devices. > > + > > + This option should be safe to enable, but if any odd probing > > + problems are found, please disable it, or dynamically turn it > > + off in the /sys/module/usbcore/parameters/multithread_probe > > + file > > + > > + When in doubt, say N. > > You sent your original patch off to Linus instead of the variant I sent > in, even though your patch violates the locking rules (see the kerneldoc > for usb_new_device)!
I did this as your variant was in the "this might possibly work but I'm not sure" type of patch :) Actually the main reason this went in is that a set of patches from you a while ago would only apply properly if my multi-threaded patch was also applied. So I moved it higher up in the patch queue and then forgot about it until right now, when you pointed out that it went into the tree... > By the way, have you observed any significant improvements in peformance > from this patch? I don't have any experience with systems having lots of > USB devices attached. For that matter, does speeding up khubd make any > significant change to the overall boot time for a system? One wouldn't > think the other boot-up steps would have to wait for khubd... No, I haven't, but I have not set up a large quantity of devices to test it with. If you want to port your old patch to apply on top of the tree right now, I'll be glad to consider it. thanks, greg k-h ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
