On Friday 08 December 2006 9:00 am, Geoff Levand wrote: > David Brownell wrote: > > It'd be advantageous to (re)use the same driver glue. ... But > > having two (or three) for Cell seems excessive, especially > > if they're all going to the same IOIF ohci controller... > > > Well yes, the underlying hardware is the same. But the firmware > and/or hypervisor is different, and that is what dictates the interface, > not the underlying hardware.
If you presume Linux is coexisting with such software, then yes. I suppose I'm more used to thinking of systems where Linux takes over, and any bootloader just gets out of the way ASAP. So that the only interface constraints are those dictated by hardware. No ACPI or BIOS headaches, or analogues thereof. > > Since your workaround is just to write some registers, I'd try > > to do that in the PS3/CELLEB bus glue. > > > But that won't work for Blade's PCI representation, which just uses > the ohci-pci code will it? Unless, you see some way that I don't. > Or, do you mean have three difffernet places where this fixup is done, > one in your new PCI fixup, then two others in the bus glue components? I'm saying that putting chip-specific workarounds in core driver code is less attractive than sticking them in bus glue that's specific to that chip ... especially in cases like this, where the workaround is essentially writing a register the boot loader ought to have written. Look at it this way: you're proposing to modify three different instances of bus glue to set a flag, AND modifying the core to write a register in response to that flag. Surely it's much more straightforward just to have the bus glue write that register directly? It's a bit less code overall (no core updates); plus, if that register gets written more conventionally (bootloader) on some instance of that Cell platform, no quirk will be needed. - Dave ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
