On 12/12/06, David Brownell <[EMAIL PROTECTED]> wrote: > > > > David, would you please look and let me know if it's something you have > > > > under control, or is it something for me to look into. > > > > > > > > Synopsys: Oops when connection nokia S60 series phone > > > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217488 > > > > > > > > A double free somewhere in an error path? > > > > > > It's not something I've looked at, no. The "rndis_host" driver > > > is "extremely" experimental though ... worked with a Linux device, > > > and one other Symbian phone. > > > > Yeah, Pasi is in bad position here, unfortunately. > > > > But my main point was about the error path. I understand that rndis > > doesn't work, but the patch was against usbnet.c, and it has > > Signed-off-by. So I thoght perhaps Dan sent it to you or to > > a list. If he hasn't, no harm done. Sorry for the trouble. > > I didn't see the patch before this moment. > > At a quick glance, I suspect the more correct fix is to make > the "goto out1;" after init fails be a "goto out3;" ... > > - Dave > >
Nah. We shouldn't need to call unbind() if bind() fails. Nov 28 08:16:16 ameeba kernel: rndis_host 1-3.6:1.14: RNDIS init failed, -32 Nov 28 08:16:16 ameeba kernel: usb%d: unregister 'rndis_host' usb-0000:00:02.1-3.6, RNDIS device It turns out that disconnect() was being called from drivers/usb/net/rndis_host.c 414 dev_err(&intf->dev, "RNDIS init failed, %d\n", retval); 415 fail: 416 usb_driver_release_interface(driver_of(intf), 417 ((struct cdc_state *)&(dev->data))->data); According to the comments on usb_driver_release_interface() it normally calls disconnect and then the probe frees net again in the error path... Probably I can remove the call to usb_driver_release_interface() and submit a patch? regards, dan carpenter ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
