On Fri, 15 Dec 2006, Pete Zaitcev wrote:
> It turned out easier than I expected. All that was necessary was to
> add #include <linux/mm.h>. Does this work for everyone? If yes, I'm
> sending it to Greg.
Two very minor comments...
> +struct usbmon_packet {
> + u64 id; /* 0: URB ID - from submission to callback */
> + unsigned char type; /* 8: Same as text; extensible. */
> + unsigned char xfer_type; /* ISO, Intr, Control, Bulk; 0x80 IN */
> + unsigned char epnum; /* Endpoint number */
The 0x80-for-IN usually goes with the endpoint number; why have you moved
it into the endpoint type byte?
> +If you create /dev/usbmon0 by hand, make sure that it is owned by root
> +and has mode 0600. Otherwise, unpriviledged users will be able to snoop
> +keyboard traffic.
No 'd' preceding the 'g' in "unprivileged".
Alan Stern
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
