Am Freitag, 22. Dezember 2006 17:18 schrieb Dmitry Torokhov:
> Hi,
> 
> On 12/20/06, Greg KH <[EMAIL PROTECTED]> wrote:

> >        dev = usb_get_intfdata (interface);
> > -       usb_set_intfdata(interface, NULL);
> >        device_remove_file(&interface->dev, &dev_attr_speed);
> > +       usb_set_intfdata(interface, NULL);
> >        usb_put_dev(dev->udev);
> >        kfree(dev);
> >  }
> 
> What does this change buy us? device_remove_file is not synchronous;
> If there is a process holding this attribute open whle disconnect is
> running it still may read/write to it after interface was set to NULL
> and dev freed.
> 
> BTW, what is this device used for? Or maybe I don't want to know...

Hi,

right now, it merely shrinks the window.
However, device_remove_file() working asynchronous is a design bug.
When would you safely call kfree? Therefore I've made a patch that makes
it synchronous. Unfortunately it is fairly invasive to sysfs. Greg is
including it into -mm. This will close the race for good.

        Regards
                Oliver

PS: Why don't you want to know? This has interesting theological
implications. Can nirvana have a resonance frequency?

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to