Hi Ben, when I tried to include the file that defined the quirks, ELAN's driver failed to compile.
Thanks for your interest in this issue. ELAN is currently in favour of open source for linux drivers of ELAN's hardware, and this type of code review can only strengthen the case. However it would be more helpful if the gentleman with with weak stomach were to put forward more constructive critisism. Tony Elan Digital Systems Limited On Fri, 2007-01-05 at 08:14 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2007-01-04 at 11:24 +0000, Tony Olech wrote: > > Hi Dave, > > > > The problem I was faced with was getting such things as the > > OHCI register layout info, and the solution I came up with > > was using the existing header file. It would certainly be > > better if the definitions pertaining to the OHCI controller > > were in a seperate header file and could be included by all > > the different drivers that require it. Such a patch would > > affect the existing driver for PCI based OHCI controllers > > as well ELAN's U132/FTDI based OHCI controller driver. > > > > Would it be OK for me to submit a patch to the existing > > OCHI driver to separate out a header-file? > > But then why did you redefine the quirks ? That's what I don't > understand. > > Ben. > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
