On Fri, Jan 05, 2007 at 07:33:40PM +0100, Oliver Neukum wrote:
> Am Freitag, 5. Januar 2007 19:10 schrieb Greg KH:
> > On Fri, Jan 05, 2007 at 02:39:21PM +0100, Oliver Neukum wrote:
> > > +
> > > +#define WDM_MINOR_BASE 32
> > 
> > Where did you get this minor number from?  I think it conflicts with a
> > very old usb driver, but you still need to reserve a real number from me
> > :)
> 
> I needed one for experimentation. This driver is not yet ready.
> But if you feel like assigning a number, I'll take it.

I'll wait until you're done :)

> > > +#include "cdc-wdm.h"
> > 
> > Do we really need a separate .h file for this driver?
> 
> Don't you like header files? They make things cleaner.

For single drivers, no, I don't like them as they are not needed.  But
it's up to you, I'll not push it.

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to