On Sun, 21 Jan 2007, Marcelo Tosatti wrote: > On Wed, Jan 03, 2007 at 09:34:57PM -0800, David Brownell wrote: > > On Friday 29 December 2006 11:26 am, Marcelo Tosatti wrote: > > <snip> > > > Move that earlier ... into the existing block of code for STS_PCD. > > As Alan mentioned that can't be done since we hold ehci->lock at that > point, and usb_hcd_poll_rh_status() attempts to acquire it. > > > Presumably you tested this and it behaves? > > Switch ehci-hcd to use the new polling scheme, which reports root > hub status changes via the interrupt handler, in an asynchronous > fashion. Doing so disables polling for status changes (whose handler is > rh_timer_func). > > Tested on a Geode GX machine, which is now capable of running at =~ 5 > timer interrupts per second (in the -rt tree), resulting in significant > power savings.
I can confirm that Marcelo's patch works correctly for most functions, however it breaks remote-wakeup detection. A followup patch to put things right will be posted shortly. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
