On Tue, 23 Jan 2007, David Brownell wrote: > On Tuesday 23 January 2007 10:29 am, Alan Stern wrote: > > On Tue, 23 Jan 2007, David Brownell wrote: > > > > > On Tuesday 23 January 2007 3:45 am, Oliver Neukum wrote: > > > \ > > > > @@ -185,6 +218,8 @@ > > > > usb_descriptor_attr(bMaxPacketSize0, "%d\n") > > > > > > > > static struct attribute *dev_attrs[] = { > > > > + /* power management attributes */ > > > > + &dev_attr_autosuspend.attr, > > > > > > Belongs in /sys/devices/.../power/... then, right? > > > > That was my thought as well. However I don't know how you would do it, > > since the PM core owns the "power" attribute group. There doesn't appear > > to be any way to add sysfs files to a group after it has been created. > > Doesn't need to be part of a group ...
Yes it does -- because /sys/devices/.../power/ is a group! > > I suppose the whole may_suspend thing could be moved into the PM core, but > > that seems a little drastic considering that only USB implements it. > > You mean the whole autosuspend infrastructure thing. Might be worth > raising that issue on the PM list. Eventually I see no reason that > most devices shouldn't autosuspend, but not many folk are paying any > attention to runtime PM at this point ... I have had in mind all along that eventually the autosuspend infrastructure should move (at least in part) into the PM core. However USB seemed like a very good proving ground for a first pass, and to go by the number of problems people seem to be having, it isn't quite yet ready for prime time. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel