On Wed, 24 Jan 2007, Chris Frey wrote: > On Tue, Jan 02, 2007 at 05:32:25PM -0800, Greg KH wrote: > > On Wed, Dec 20, 2006 at 11:05:44PM -0500, Alan Stern wrote: > > > On Wed, 20 Dec 2006, Greg KH wrote: > > > > > > > From: Chris Frey <[EMAIL PROTECTED]> > > > > > > > > When sending CONTROL URB's using the usual CONTROL ioctl, logging works > > > > fine, but when sending them via SUBMITURB, like VMWare does, the > > > > control fields are not logged. This patch fixes that. > > > > > > > > I didn't see any major changes to devio.c recently, so this patch > > > > should apply > > > > cleanly to even the latest kernel. I can resubmit if it doesn't. > > > > > > > > From: Chris Frey <[EMAIL PROTECTED]> > > > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > --- > > > > drivers/usb/core/devio.c | 6 +++++- > > > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > > > index 3ed4cb2..4b3a6ab 100644 > > > > --- a/drivers/usb/core/devio.c > > > > +++ b/drivers/usb/core/devio.c > > > > @@ -962,7 +962,11 @@ static int proc_do_submiturb(struct dev_state *ps, > > > > struct usbdevfs_urb *uurb, > > > > kfree(dr); > > > > return -EFAULT; > > > > } > > > > - snoop(&ps->dev->dev, "control urb\n"); > > > > + snoop(&ps->dev->dev, "control urb: bRequest=%02x " > > > > + "bRrequestType=%02x wValue=%04x " > > > > + "wIndex=%04x wLength=%04x\n", > > > > + dr->bRequest, dr->bRequestType, dr->wValue, > > > > + dr->wIndex, dr->wLength); > > > > break; > > > > > > > > case USBDEVFS_URB_TYPE_BULK: > > > > > > This patch slipped past me when it was submitted... It contains a > > > reasonably serious error. The two-byte quantities in dr are stored in > > > little-endian format; they need to be converted to host-endian before > > > printing. > > > > Good catch. > > > > Chris, care to make up a fix for this? > > I apologise, this got routed to the wrong mailbox and I missed it. > > I don't see any endian fixes in the latest prepatch... is this fix > still needed?
Yes, it still is. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
