Am Samstag, 27. Januar 2007 00:13 schrieb Greg KH:
> On Fri, Jan 26, 2007 at 02:26:21PM +0100, Oliver Neukum wrote:
> > Hi,
> >
> > this is the newest version of the patch to introduce a blacklist.
> >
> > - It handles autosuspend oddities and problems with string descriptors
> > - It exports the detected quirks through sysfs
> >
> > It compiles and detects quirky devices.
>
> Here's a revised patch based on yours. I used the existing structure we
> have for describing usb devices, as it can handle any type we want to
> throw at it. This also lets us re-use the logic of matching an id to a
> device.
>
> It simplified the code a bit too.
I am compiling.
> I moved the table into the .c file, as data shouldn't be in a .h file.
Very well, but it should be in a separate file.
> Changed the quirk to be a 32bit value, to be safe on all platforms.
Where would you use "int" at all?
> And added the blackberry to the list, so I can test this out.
You can't do this unconditionally. Secondly, even with your driver
one might not want to charge a blackberry, eg. when running on
battery oneself.
> I'll work on the sysfs interface next, as we need a way to set these
> quirks from userspace somehow...
Very well, but you might first look into the patch for switching on and
off autosuspend I've posted last week. Quirks should be for true errors,
not convenience.
Secondly, for now we have only serious errors in quirks. If your device
crashes during probe, writing them from userspace will do no good.
Regards
Oliver
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
