Am Samstag, 3. Februar 2007 17:10 schrieben Sie:
> On Sat, Feb 03, 2007 at 04:18:24PM +0100, Oliver Neukum wrote:
> > 1. Why not simply take the lock earlier?
> 
> And call the tty layer under acm->throttle_lock? I think not.

No, it would deadlock, you are right.

> We could of course read acm->throttle once under the lock and
> store its value in a local variable. I can write it like that if
> you prefer it, but I actually think that my solution is simpler since
> it never needs to push buffers back on filled_read_bufs.

Did you test this with ehci? Unless we know for sure that even with
the larger packet size the tty layer can cope, I want to be conservative.

        Regards
                Oliver

PS: The other two patches with "Signed-off-by" lines, please.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to