On Tue, 13 Feb 2007, Edwin Olson wrote: > Hello folks, > > I've incorporated the suggestions mentioned before, and a few other > cleanups. Anecdotally, the module seems to be performing very well on my > system (x86-64). Not withstanding recent development work to > usbfs/libusb, I think that this makes a great deal of sense as a kernel > module as it provides a fairly generic and useful capability that could > serve many USB gadgets. I'm hoping that you (mostly Greg) will be > amenable to it in preference to a libusb solution! > > With any luck, if this code looks in decent shape, my next submission > will be in the form of a patch against 2.6.20-gitXX.
There are several stylistic issues you should fix. The most noticeable is failure to observe the 80-column rule. Call spin_lock_init() instead of assigning SPIN_LOCK_UNLOCKED. Use the driver-model macros dev_err(), dev_info(), etc. instead of err() and info(). Do you really want to start a read as soon as the driver is registered? Why not wait until a user process opens the device file? That way you could leave the device suspended whenever its file was closed. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
