On Thu, 1 Mar 2007, Oliver Neukum wrote: > > Actually I had in mind something simpler, like getting rid of the > > GET_DESCRIPTOR_TRIES loop for i (or reducing it to one attempt using the > > new scheme and one attempt using the old scheme) and getting rid of the > > SET_ADDRESS_TRIES loop for j, both in hub_port_init(). > > I would prefer to try very hard once. This is what this patch does.
Take a look at this log from a little over a year ago: http://marc.theaimsgroup.com/?l=linux-usb-devel&m=113521633114762&w=2 Len Brown had a docking station with an internal hub that wasn't working right. It is device 3-5; we start trying to enumerate it at time stamp 40.129703 and give up at timestamp 103.761001. That's just ridiculous. Not to mention unfriendly, since khubd is unavailable for anything else during that time _and_ it holds the root hub's device lock, preventing many other things from working. Trying hard is fine, but to keep on trying for over 60 seconds is foolish. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel