On Thu, 8 Mar 2007 00:02:48 +0100, "Rene van Paassen" <[EMAIL PROTECTED]> wrote:

I don't mind this:

> Signed-off-by: René van Paassen <[EMAIL PROTECTED]>

This non-ASCII character is in the changelog, so it won't cause any
spurious patch rejections. But this is bad:

> + *  Extra bits    2004      René van Paassen <[EMAIL PROTECTED]>
> +#define DRIVER_AUTHOR  "Bryan W. Headley/Chris Atenasio/Cédric
> Brun/René van Paassen"

Please understand, patches are commonly sent naked in the mail, even
in this enlightened day of git and MIME. So, even if you send it right,
eventually someone else will patch your code, diff context will
catch the name, and...

Your patch was line-wrapped, so you'll need to resend it anyway.
While addressing that, please consider my request too.

Yours,
-- Pete

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to