This is a note to let you know that I've just added the patch titled

     Subject: USB: fix spinlock recursion in cdc-acm.c

to my gregkh-2.6 tree.  Its filename is

     usb-fix-spinlock-recursion-in-cdc-acm.c.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From [EMAIL PROTECTED] Tue Mar  6 01:47:02 2007
From: Oliver Neukum <[EMAIL PROTECTED]>
Date: Tue, 6 Mar 2007 10:47:04 +0100
Subject: USB: fix spinlock recursion in cdc-acm.c
To: [EMAIL PROTECTED], Pete Zaitcev <[EMAIL PROTECTED]>, "list, USB" 
<linux-usb-devel@lists.sourceforge.net>
Message-ID: <[EMAIL PROTECTED]>
Content-Disposition: inline


this fixes the spinlock recursion issue. The older fix was incomplete.


Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Acked-by: Pete Zaitcev <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

--- a/drivers/usb/class/cdc-acm.c       2007-03-06 10:39:50.000000000 +0100
+++ b/drivers/usb/class/cdc-acm.c       2007-03-06 10:39:55.000000000 +0100
@@ -332,9 +332,9 @@
        if (!ACM_READY(acm))
                return;
 
-       spin_lock(&acm->throttle_lock);
+       spin_lock_irqsave(&acm->throttle_lock, flags);
        throttled = acm->throttle;
-       spin_unlock(&acm->throttle_lock);
+       spin_unlock_irqrestore(&acm->throttle_lock, flags);
        if (throttled)
                return;
 
@@ -352,9 +352,9 @@
        dbg("acm_rx_tasklet: procesing buf 0x%p, size = %d", buf, buf->size);
 
        tty_buffer_request_room(tty, buf->size);
-       spin_lock(&acm->throttle_lock);
+       spin_lock_irqsave(&acm->throttle_lock, flags);
        throttled = acm->throttle;
-       spin_unlock(&acm->throttle_lock);
+       spin_unlock_irqrestore(&acm->throttle_lock, flags);
        if (!throttled)
                tty_insert_flip_string(tty, buf->base, buf->size);
        tty_flip_buffer_push(tty);


Patches currently in gregkh-2.6 which might be from [EMAIL PROTECTED] are


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to