Am Dienstag, 27. März 2007 19:43 schrieb Pete Zaitcev:
> On Tue, 27 Mar 2007 14:30:52 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
>
> > --- a/drivers/usb/serial/option.c 2007-03-27 13:31:04.000000000 +0200
> > +++ b/drivers/usb/serial/option.c 2007-03-27 14:21:21.000000000 +0200
> > @@ -627,14 +629,23 @@
> > + *buf = usb_buffer_alloc(serial->dev, len, GFP_KERNEL, handle);
> > /* Fill URB using supplied data. */
> > usb_fill_bulk_urb(urb, serial->dev,
> > usb_sndbulkpipe(serial->dev, endpoint) | dir,
> > - buf, len, callback, ctx);
> > + *buf, len, callback, ctx);
> > + urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
> > + urb->transfer_dma = *handle;
>
> Why don't you just use kmalloc here? The needless use of usb_buffer_alloc
> always irritates me. It's as if the iommu space is free and endless.
Very well, I'll code something more conservative.
Regards
Oliver
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
