On Mon, 16 Apr 2007, Li Yu wrote:
> HID bus prototype 20070416
Hi Li,
thanks for taking care. Well, the patch is quite huge, do you think you
could split it into separate independent parts (use quilt or something
similar for patch management) which could be reviewed independently?
As the code changes are often quite non-trivial, layering is changed,
lots of files are touched, etc. it would help a lot.
Notes from a quick skim through the patch:
- it seems that you accidentaly deleted the newly added quirk for
mightymouse in the bluetooth hid code?
- what is the point behind HID_QUIRK_SKIP? Why doesn't HID_QUIRK_IGNORE
suffice? And why is it defined in so strange way:
@@ -270,6 +271,7 @@ struct hid_item {
#define HID_QUIRK_LOGITECH_DESCRIPTOR 0x00100000
#define HID_QUIRK_DUPLICATE_USAGES 0x00200000
#define HID_QUIRK_RESET_LEDS 0x00400000
+#define HID_QUIRK_SKIP 0x80000000
- there are bunches of some easy codingstyle issues (spaces around '=',
etc)
But doing really thorough review is quite hard, as the patch contains lots
of unrelated changes. I'll look at it a little bit more, but when you send
a broken-out version with separate changes, that'd be great.
Thanks,
--
Jiri Kosina
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
