On Thu, 10 May 2007 01:24:17 +0200, Jochen Karrer <[EMAIL PROTECTED]> wrote:

I agree that the code is clearly broken. There's lot more wrong going
on in there, like the confusion over what 'err' is.

> How is the intended error behaviour ? Should usblp_write simply retry
> forever or should the system call return with an error ? Should there be
> a retry limit ?

IMHO, write(2) should report the error instead of retrying it silently,
because there's too much chance of corruption of the stream is present
otherwise. On my printer at least, ignoring an error is almost certain
to waste a ton of paper. Somehow the PCL stream is not self-syncing, and
instead of wasting just one page it will waste everything. However,
if legacy behaviour has retries, I'll take care to keep them.

I'll look at your problem soon (no, really - "soon" means in the next
few days).

-- Pete

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to