> -----Original Message----- > From: David Brownell [mailto:[EMAIL PROTECTED] > Sent: Friday, May 11, 2007 4:03 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linux-usb-devel@lists.sourceforge.net > Subject: Re: [PATCH] ehci_fsl update for MPC831x support > > On Wednesday 09 May 2007, Li Yang wrote: > > For MPC831x support, change the ehci-fsl driver to preserve > > bits set in platform code. Add a common CONFIG_USB_EHCI_FSL > > to indicate presence of Freescale EHCI SOC. Add FSL_USB2_DR_OTG > > operating mode support, thus both host and device can work for the > > mini-ab receptacle. Note: this doesn't enable OTG protocol > > support. > > > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > > Looks pretty much OK, but see below. > > > > --- > > drivers/usb/host/Kconfig | 6 ++++++ > > drivers/usb/host/ehci-fsl.c | 10 +++++++--- > > drivers/usb/host/ehci-hcd.c | 2 +- > > 3 files changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > > index 6271187..8da3185 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -72,6 +72,12 @@ config USB_EHCI_BIG_ENDIAN_MMIO > > depends on USB_EHCI_HCD > > default n > > > > +config USB_EHCI_FSL > > + bool > > + default n > > + ---help--- > > + Variation of ARC USB block used in some Freescale chips. > > So does that mean a "select USB_EHCI_ROOT_HUB_TT" is missing? > Or is that part of the variation?
No, we still need USB_EHCI_ROOT_HUB_TT. This option is used to indicate the presence of Freescale EHCI SoC which is a variation of ARC USB. EHCI_ROOT_HUB_TT is part of the variation; maybe we can make it automatically select EHCI_ROOT_HUB_TT. > > And: who sets USB_EHCI_FSL? Shouldn't there be a > "default y if MPC831x || MPC834x" etc? It is set in platform Kconfig. Like: config PPC_MPC831x bool select PPC_UDBG_16550 select PPC_INDIRECT_PCI select USB_EHCI_FSL default y if MPC8313_RDB - Leo ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel