Deepak Saxena wrote: > On May 07 2007, at 10:53, Vladimir Barinov was caught saying: > >> This patch adds support for Intel IXP4XX EHCI USB controller. >> >> Since it's MMR and descriptors are represented in big-endian format then >> this patch is to be applied after the following patches posted to this list: >> - ehci cpufreq patch >> - EHCI big endian data structures support >> - Set CONFIG_USB_EHCI_BIG_ENDIAN_MMIO/_DESC in usb/host/Kconfig >> - Safe endianness for transfer buffers after reset in case of HUB with TT >> >> Signed-off-by: Vladimir Barinov <[EMAIL PROTECTED]> >> >> --------- >> >> --- usb-2.6.orig/drivers/usb/host/ehci.h 2007-05-03 >> 14:17:41.000000000 +0400 >> +++ usb-2.6.new/drivers/usb/host/ehci.h 2007-05-03 14:26:38.000000000 +0400 >> @@ -734,6 +734,11 @@ ehci_port_speed(struct ehci_hcd *ehci, u >> #define writel_be(val, addr) out_be32((__force unsigned *)addr, val) >> #endif >> >> +#if defined(CONFIG_ARM) >> +#define readl_be(addr) __raw_readl((__force unsigned *)addr) >> +#define writel_be(val, addr) __raw_writel(val, (__force unsigned *)addr) >> +#endif >> + >> > > readl_be == __raw_readl only in the IXP4xx ARM case as ARM is normally > LE, so I think this sould probably be CONFIG_ARM && CONFIG_IXP4XX (in > Deepak, thx for these comment. To be more correct you've meant: #if defined(CONFIG_ARM) && defined(CONFIG_ARCH_IXP4XX) > case there is !ARM IXP4XX at some point). > You are right that the ARCH_IXP4XX is the only BE. But I'm not sure is it really possible to have new IXP4XX processor family that will be !ARM. Also if that really will happen then the "#if defined(CONFIG_ARM)" will not let for !ARM processor to use the above definition, hence the additional defined(CONFIG_ARCH_IXP4XX) is useless.
Vladimir ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
