Dave: Do we really need to call finish_port_resume() for root hubs? It doesn't do much for them except to set the device state, which could just as easily be done in hcd_bus_resume().
The same question applies to root hubs and __usb_port_suspend(). In fact, it would be very easy to change the usb_generic driver so that it called usb_port_suspend() and usb_port_resume() only for non-root devices. Then those routines would never be invoked for devices with no upstream port, allowing us to save a few tests. Unless they get used for OTG? There is a funny-looking call to __usb_port_suspend in the OTG part of usb_new_device. (I'm not clear on why it doesn't call usb_port_suspend instead.) But it still isn't trying to suspend a root hub, so the proposed changes should be okay. Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
