On Wed, 2007-05-23 at 21:17 -0700, Phil Dibowitz wrote:
> Note, I've taken LKML off the CC list anyone interested in this on there is
> also on linux-usb-devel. I've also added the usb-storage list.
> 
> See rest of response below.
> 
> Ben Collins wrote:
> >>> +/* SanDisk that has a second LUN for a driver ISO, reported by
> >>> + * Ben Collins <[EMAIL PROTECTED]> */
> >>> +UNUSUAL_DEV( 0x0781, 0x5406, 0x0000, 0xffff,
> >> Please use specific device IDs unless you have reason to believe the range
> >> as a whole is affected (or large portions at least)
> > 
> > Unfortunately, I don't have this device anymore. I based it on an
> > existing entry, so mislead myself there.
> 
> I don't like to merge these because it means some other user of some new
> device can get unintended consequences - but if we don't have access to the
> data, it's better than nothing. Were you the person who owned the device? If
> not, do you still have the contact info - perhaps in a bugzilla or BTS
> somewhere?

For this device, yes.


> >>> +/* Reported by Edward Chapman <[EMAIL PROTECTED]>
> 
> No need to have EMAIL PROTECTED there. Just don't put it in. However, as
> much as I don't like entries that span entire bcdDevice IDs, I like even
> *less* entries that don't let me go back to the original user when I'm
> considering a patch that may well _break_ their device. So please consider
> adding it in a foo _at_ bar _dot_ com notation, or making yourself the
> contact, or if you must, just leave his name.

That's what the mailing list archive had in it :) Copy-and-paste

> >>> +   Netac OnlyDisk Mini U2CV2 512MB USB 2.0 Flash Drive */
> >>> +UNUSUAL_DEV( 0x0dd8, 0xd202, 0x0000, 0x9999,
> >> Same here.
> > 
> > This one I snatched off a mailing list archive somewhere. Was reported
> > to fix a bug reported to us. However, it is so old I can't find any
> > information on the bug submitters original USB ids.
> 
> Eh - I'm a bit confused. You snatched the entry as a whole off of a mailing
> list? One would then assume it wasn't this list, or the entry would have
> been merged or rejected. This makes me question if this entry is validly
> needed. US_FL_IGNORE_RESIDE is a bad thing to do is if it's not actually 
> needed.

IIRC, the bug report pointed to this diff, had reported that it fixed
his problem after recompiling and testing with it.

-- 
Ubuntu   : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to