On Sat, Jun 09, 2007 at 05:14:14PM -0400, Alan Stern wrote: > On Fri, 8 Jun 2007, Greg KH wrote: > > > On Fri, Jun 08, 2007 at 05:12:05PM -0400, Alan Stern wrote: > > > This patch (as926) replaces urb->status with urb->core_status, in an > > > attempt to help prevent drivers from abusing the API by polling > > > urb->status. The original field remains for use by drivers, but it > > > isn't set until an URB is about to be handed to its completion > > > routine. > > > > Hm, is there any way to keep this from being in the urb entirely? > > Shouldn't this be an internal-to-the hcd type thing? > > Yes, it could be done that way, I think. It'll take more work than a > simple search-and-replace. The trickiest part is how to unlink an URB > after it has been submitted but before it has been handed to the HCD...
We allow that today? How, multiple threads doing the submit and then unlink call? That's looney. We should not worry about that until after the submit call has returned to the caller. Would that make this easier then? > > I say this as I worry people will just start using core_status instead > > of status when we remove the status field. > > Maybe. It _is_ documented as being private to usbcore -- but that > might not stop people! Exactly, we need to make it impossible :) If I get the chance this week I'll look at your patch and see if we can tweak it somehow. usbmon might throw a problem into the loop I need to see what it needs for the status... thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
