On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote: > >>>>> "Grant" == Grant Likely <[EMAIL PROTECTED]> writes: > > Hi, > > Grant> Rather than c67x00-hub.c being compiled seperately, the > Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c. > Grant> This is a very bad idea. Simplest solution is to merge the > Grant> two files into one and be done with it. > > Yeah, it isn't exactly pretty, but it's what the other hcd drivers do, > E.G.: > > % grep -rs "include.*hub.c" *c > ehci-hcd.c:#include "ehci-hub.c" > ohci-hcd.c:#include "ohci-hub.c" > uhci-hcd.c:#include "uhci-hub.c" > > I don't quite know why they do it like that though ..
True, but that doesn't mean that it's a good idea to follow the lead. There are lots of other examples of ugly code in the kernel that is tolerated just because nobody has cleaned it up yet, but is still unacceptable for new code. We know it's an ugly thing to do, and the fix is simple and easy. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. [EMAIL PROTECTED] (403) 399-0195 ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
