On Fri, 15 Jun 2007 12:55:42 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote:

> > Autosuspend kills printers
> >  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243038

> By the way, the symptoms with the two printers weren't quite the same.  
> dave's disconnected itself, but Barry's issued a remote wakeup request 
> (in spite of the fact that remote wakeup wasn't enabled) and then 
> failed to respond to a Get-Device-Status query -- it returned 1 byte 
> instead of 2.  That failure is why it was disconnected.

So, should we do something like this, then:

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 739f520..971c7ad 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -32,6 +32,8 @@ static const struct usb_device_id usb_quirk_list[] = {
        { USB_DEVICE(0x03f0, 0x0701), .driver_info = USB_QUIRK_STRING_FETCH_255 
},
        /* Seiko Epson Corp - Perfection 1670 */
        { USB_DEVICE(0x04b8, 0x011f), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
+       /* Samsung ML-2010: wakes up by itself and cycles; bad GET_STATUS */
+       { USB_DEVICE(0x04e8, 0x326c), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
        /* Elsa MicroLink 56k (V.250) */
        { USB_DEVICE(0x05cc, 0x2267), .driver_info = USB_QUIRK_NO_AUTOSUSPEND },
 

And then there's the Prolific, and maybe a bunch of others as well.

I am wondering if we should issue GET_STATUS for device first and see
how that goes. If it fails, disable the autosuspend. Although, what
to do if it crashes the device? We'd need to forward this knowledge
to the newly reconnected device somehow, maybe with some kind of a
dynamic blacklist...

-- Pete

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to