On Sat, Jun 30, 2007 at 09:31:02AM +0200, Oliver Neukum wrote: > Am Samstag, 30. Juni 2007 schrieb Greg KH: > > On Fri, Jun 29, 2007 at 03:18:23PM -0700, David Brownell wrote: > > > > > > > > Gaak. Just pass the usb_host_endpoint pointer in, with the relevant > > > > > length indicator. Four functions would be ugly, unclean, unneceesary. > > > > > All the relevant data is in the endpoint descriptor, which is stored > > > > > in the host_endpoint struct. > > > > > > > > This would be true, were it not for those drivers which use interrupt > > > > URBs > > > > on bulk endpoints. > > > > > > It's still true. You should never make such oddball exceptions > > > into a special case around which an API is defined ... they should > > > stay oddball exceptions. Like in this case, patching up the URB > > > after it's set up would suffice. (And look sufficiently ugly that > > > driver writers couldn't excuse themselves by "I didn't know I was > > > not supposed to do that.) > > > > I agree, passing the usb_host_endpoint pointer would be the easiest way > > to do this. > > So do we have consensus for this prototype: > > struct urb *usb_alloc_urb(struct usb_host_endpoint *ep, unsigned int > max_length, unsigned int iso_fields, gfp_t mem_flags);
Looks good to me, but let's see what the resulting code looks like before saying it's the final version :) thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
