Unfortunately I can not myself comment on the feature at this point, however the code is pretty obvious :).
I'll go ahead and change it so that it returns the result of sierra_set_ms_mode. Also, I realized that the second patch (02/02) fixes a bug in the first patch (01/02), particularly the dev_dbg messages are implemented incorrectly in the first patch. I'll move that fix up to the first patch. I'll wait another day for other comments and then resubmit with those changes. - Kevin -----Original Message----- From: Oliver Neukum [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 11, 2007 3:37 PM To: linux-usb-devel@lists.sourceforge.net Cc: Kevin Lloyd; [EMAIL PROTECTED]; Linux Development Group; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [linux-usb-devel] [PATCH 01/02] Sierra Wireless - Add TRU-Install (c) Support Am Donnerstag, 12. Juli 2007 schrieb Kevin Lloyd: > From: Kevin Lloyd <[EMAIL PROTECTED]> > > This patch adds compatibility with Sierra Wireless' new TRU-Install feature. Future devices that use this feature will not work unless this patch has been applied. Is this some type of CD-ROM simulation to provide drivers? > +int sierra_probe(struct usb_interface *iface, const struct > +usb_device_id *id) { > + int result; > + struct usb_device *udev; > + > + udev = usb_get_dev(interface_to_usbdev(iface)); > + > + /* Check if in installer mode */ > + if (id->driver_info == DEVICE_INSTALLER){ > + dev_dbg("FOUND DEVICE(SW)\n"); > + result = sierra_set_ms_mode(udev, SWIMS_SET_MODE_Modem); > + return 0; This is not a good idea in the long run. If you don't return an error here, disconnect() will be called for your driver and will have to deal with a semiinitialized device. Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
