On Tuesday 17 July 2007, Yoshihiro Shimoda wrote: > Thank you very much for your comment. > I made the patch. Should I send following patch to Greg?
It's probably already in his inbox, but a direct CC on the next version might help. I only really have one comment, and it relates to the patch description ... I'm assuming you did the right thing combining the other patches, as a quick lookover says you did. > Thanks, > Y.Shimoda > > ========= CUT HERE > This patch incorporates some updates from the review of the > Renesas m66592-udc driver. Updates include: > > - Fix some locking bugs; and add a few sparse annotations > - Don't #define __iomem ! > - Lots of whitespace fixes (most of the patch by volume) > - Some #include file trimmage > - Other checkpatch.pl and sparse updates > - Alphabetized and slightly-more-informative Kconfig > - Don't use the ID which was assigned to the amd5536udc driver. > - Remove pointless suspend/resume methods updating obsolete field. > - Some section fixups > - Fix some leak bugs > - Fix byteswapping > > More importantly for the moment, it gets the driver to build again; the > original version included broken versions of since-removed methods. Remove that last paragraph; that got fixed already. > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > Signed-off-by: Yoshihiro Shimoda <[EMAIL PROTECTED]> Thanks for doing this. It's good to see more of these drivers, even when something goes wrong in the merge! Next trick will be to get more Linux boxes using this chip. ;) - Dave ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
