Hello guys, I do have the device here,
kernel 2.6.17.13
I'll start testing as soon as I get home from work ;)
br
On Thu 19 Jul 2007 13:21, Domen Puncer wrote:
> On 19/07/07 11:36 -0500, Alex Villacís Lasso wrote:
> > At last I managed to fix the problem with transfers with the dongle. It
> > happens that this dongle does not support payloads larger than 256
> > bytes, so the driver has to manually fragment anything bigger.
> >
> > The version attached in the tarball is the first version I consider
> > worthy to submit for inclusion in the kernel. Please review (and test,
> > if you can) as much as you like, before sending this to Samuel Ortiz,
> > who maintains the IrDA subsystem. There is both the version to compile
> > out-of-kernel (Makefile and .c file) as well as the version to apply to
> > the kernel itself (on top of clean 2.6.22).
>
> Unfortunately I don't have the dongle here, so I can't test.
> It would be great to get it into mainline, while the window is still
> open though.
>
> Some minor comments/nits:
>
> 334 /* unlink, shutdown, unplug, other nasties */
> 335 if (urb->status != 0) {
> 336 err("ks959_send_irq: urb asynchronously failed - %d",
> urb->status); 337 }
> no return? it is in _rcv_irq
>
> 460 kingsun->receiving = (kingsun->rx_unwrap_buff.state !=
> OUTSIDE_FRAME) ? 1 : 0; just "kingsun->receiving =
> kingsun->rx_unwrap_buff.state != OUTSIDE_FRAME;" would do the trick, but I
> don't really care.
>
> 721 kingsun->rx_buf = (__u8 *)kmalloc(KINGSUN_RCV_FIFO_SIZE,
> GFP_KERNEL); no need to cast (void *).
>
> > Alex Villacís Lasso
> >
> > --
> > perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
