On Tue, 24 Jul 2007, Pete Zaitcev wrote:

> On Tue, 24 Jul 2007 16:46:21 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> 
> wrote:
> 
> >  static int usb_start_wait_urb(struct urb *urb, int timeout, int 
> > *actual_length)
> >  { 
> > -   struct completion done;
> > +   struct api_context ctx;
> >     unsigned long expire;
> >     int retval;
> > -   int status = urb->status;
> >  
> > -   init_completion(&done);         
> > -   urb->context = &done;
> > +   init_completion(&ctx.done);
> > +   urb->context = &ctx;
> >     urb->actual_length = 0;
> >     retval = usb_submit_urb(urb, GFP_NOIO);
> 
> Oh. My. God.

I'm not quite sure what to make of your reaction.  :-)  Let's see what 
Greg has to say...

Actually, callback structures like this are not at all uncommon.  So 
you shouldn't worry that it looks a little awkward.

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to