On Sun, Jul 29, 2007 at 05:15:41PM -0400, Robert P. J. Day wrote: > On Sun, 29 Jul 2007, Greg KH wrote: > > > On Sun, Jul 29, 2007 at 04:17:57PM -0400, Robert P. J. Day wrote: > > > > > > the latest output of the "dead CONFIG variable" script run against > > > the directory drivers/usb (obviously some false positives, but some > > > definitely dead variables): > > > > Care to make up some patches to fix these? > > which ones? are you saying they're *all* dead? that can't be > possible since at least one is a fake CONFIG variable: > > ========== USB_SAFE_PADDED ========== > drivers/usb/serial/safe_serial.c:77:#ifndef CONFIG_USB_SAFE_PADDED > drivers/usb/serial/safe_serial.c:78:#define CONFIG_USB_SAFE_PADDED 0 > drivers/usb/serial/safe_serial.c:83:static int padded = > CONFIG_USB_SAFE_PADDED; > > in cases like that, i prefer to just rename the variable so it no > longer resembles a Kconfig variable. but the rest of them are all > removable? i'd probably submit a small set of patches, each one to > handle a related set of those variables, if that's what you want.
It all depends, some of them might just be typos, just like this one (hint, it is a Kconfig option, just mis-named...) And others, well, they might be dead, I don't know. thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
