Setup packet must be visible in virtual space. There's absolutely no
good reason to implement any kind of zero-copy transfer of 8 bytes, and
the documentation in usb.h is explicit about it. So, drop DMA remapping.

Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>

diff -urp -X dontdiff linux-2.6.23-rc3-gregkh/drivers/usb/mon/mon_bin.c 
linux-2.6.23-rc3-gregkh-pipe/drivers/usb/mon/mon_bin.c
--- linux-2.6.23-rc3-gregkh/drivers/usb/mon/mon_bin.c   2007-08-13 
22:44:06.000000000 -0700
+++ linux-2.6.23-rc3-gregkh-pipe/drivers/usb/mon/mon_bin.c      2007-08-14 
00:01:23.000000000 -0700
@@ -357,10 +361,6 @@ static inline char mon_bin_get_setup(uns
        if (!usb_endpoint_xfer_control(&urb->ep->desc) || ev_type != 'S')
                return '-';
 
-       if (urb->dev->bus->uses_dma &&
-           (urb->transfer_flags & URB_NO_SETUP_DMA_MAP)) {
-               return mon_dmapeek(setupb, urb->setup_dma, SETUP_LEN);
-       }
        if (urb->setup_packet == NULL)
                return 'Z';
 
diff -urp -X dontdiff linux-2.6.23-rc3-gregkh/drivers/usb/mon/mon_text.c 
linux-2.6.23-rc3-gregkh-pipe/drivers/usb/mon/mon_text.c
--- linux-2.6.23-rc3-gregkh/drivers/usb/mon/mon_text.c  2007-08-13 
22:44:06.000000000 -0700
+++ linux-2.6.23-rc3-gregkh-pipe/drivers/usb/mon/mon_text.c     2007-08-14 
00:21:22.000000000 -0700
@@ -127,10 +127,6 @@ static inline char mon_text_get_setup(st
        if (ep->xfertype != USB_ENDPOINT_XFER_CONTROL || ev_type != 'S')
                return '-';
 
-       if (urb->dev->bus->uses_dma &&
-           (urb->transfer_flags & URB_NO_SETUP_DMA_MAP)) {
-               return mon_dmapeek(ep->setup, urb->setup_dma, SETUP_MAX);
-       }
        if (urb->setup_packet == NULL)
                return 'Z';     /* '0' would be not as pretty. */
 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to