On Thu, Jun 19, 2003, Luck, Tony <[EMAIL PROTECTED]> wrote: > > Tony> While trying to compile the latest pull from > Tony> the lia64.bkbits.net:8080/linux-ia64-2.5 > Tony> repository I hit the "you_cannot_kmalloc_that_much" > Tony> message in the final link. > > Tony> The culprit is in > Tony> drivers/usb/host/uhci-debug.c > Tony> which contains: > > Tony> #define MAX_OUTPUT (PAGE_SIZE * 16) > Tony> ... > Tony> up-> data = kmalloc(MAX_OUTPUT, GFP_KERNEL); > > Tony> With the ia64 default 16k page size we are trying to > Tony> allocate 256K of memory, which is bigger that the > Tony> largest size pool in include/linux/kmalloc_sizes.h > > > Tony> Do we need a larger pool (I don't think so) or is > Tony> this allocation excessive? > > David> Clearly the latter. If it works with 4KB page size on x86, > David> certainly we don't need 4 or 8 times more space on ia64. > > David> Can you take this up directly with the author of the offending line? > > How much space do we really need to allocate here? Can we > just change the define to a fixed 64k, or is this really > dependent on the page size of the OS? > > Trivial patch attached
The space needed should be consistent across all architectures. The patch you made should be good. Of course, an ever better patch is to fix the hideous UHCI debugging code, but that's a lot more work :) JE ------------------------------------------------------- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-users
