On Sat, Mar 20, 2004 at 08:59:33PM +0100, Marc-Christian Petersen wrote:
> Hi Greg,
>
> seems $subject is still valid for 2.6, no? - 2.4 got a fix 11 weeks ago.
>
> See this:
> http://linux.bkbits.net:8080/linux-2.4/diffs/drivers/usb/[EMAIL PROTECTED]|
> src/|src/drivers|src/drivers/usb|hist/drivers/usb/vicam.c
>
> Please apply.
>
> ciao, Marc
> # drivers/usb/media/vicam.c | 13 ++++++++++---
> # 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff -urN linux-old/drivers/usb/media/vicam.c
> linux-wolk-for-2.6drivers/usb/media/vicam.c
> --- linux-old/drivers/usb/media/vicam.c 2003-11-28 10:26:20.000000000 -0800
> +++ linux-wolk-for-2.6drivers/usb/media/vicam.c 2004-01-15 12:10:23.000000000
> -0800
> @@ -653,12 +653,19 @@
> case VIDIOCSWIN:
> {
>
> - struct video_window *vw = (struct video_window *) arg;
> - DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);
> + struct video_window vw;
>
> - if ( vw->width != 320 || vw->height != 240 )
> + if (copy_from_user(&vw, arg, sizeof(vw)))
> + {
Care to implement proper coding style here?
And for some reason I thought this was already fixed in 2.6... guess
not.
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users
