Looks reasonable.

Greg, please apply.

Matt

Signed-off-by: Matthew Dharm <[EMAIL PROTECTED]>

On Thu, Aug 31, 2006 at 10:24:03PM +0200, Cedric Le Goater wrote:
> Matthew Dharm wrote:
> 
> > The URL in MAINTAINERS is correct, please don't remove it.  The server
> > seems to need fixing, however... I'll make sure that gets done.
> 
> ok.
> 
> I've fixed the patch to remove the MAINTAINERS file.
> 
> thanks,
> 
> C.
> 
> 
> Replaced kernel_thread() with kthread_run() since kernel_thread() is
> deprecated in drivers/modules.
> 
> Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]>
> Cc: Matthew Dharm <[EMAIL PROTECTED]>
> Cc: Alan Stern <[EMAIL PROTECTED]>
> Cc: linux-usb-users@lists.sourceforge.net
> Cc: [EMAIL PROTECTED]
> 
> ---
>  drivers/usb/storage/libusual.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Index: 2.6.18-rc4-mm3/drivers/usb/storage/libusual.c
> ===================================================================
> --- 2.6.18-rc4-mm3.orig/drivers/usb/storage/libusual.c
> +++ 2.6.18-rc4-mm3/drivers/usb/storage/libusual.c
> @@ -8,6 +8,7 @@
>  #include <linux/usb.h>
>  #include <linux/usb_usual.h>
>  #include <linux/vmalloc.h>
> +#include <linux/kthread.h>
> 
>  /*
>   */
> @@ -117,7 +118,7 @@ static int usu_probe(struct usb_interfac
>                        const struct usb_device_id *id)
>  {
>       unsigned long type;
> -     int rc;
> +     struct task_struct* task;
>       unsigned long flags;
> 
>       type = USB_US_TYPE(id->driver_info);
> @@ -132,8 +133,9 @@ static int usu_probe(struct usb_interfac
>       stat[type].fls |= USU_MOD_FL_THREAD;
>       spin_unlock_irqrestore(&usu_lock, flags);
> 
> -     rc = kernel_thread(usu_probe_thread, (void*)type, CLONE_VM);
> -     if (rc < 0) {
> +     task = kthread_run(usu_probe_thread, (void*)type, "libusual_%d", type);
> +     if (IS_ERR(task)) {
> +             int rc = PTR_ERR(task);
>               printk(KERN_WARNING "libusual: "
>                   "Unable to start the thread for %s: %d\n",
>                   bias_names[type], rc);
> @@ -175,8 +177,6 @@ static int usu_probe_thread(void *arg)
>       int rc;
>       unsigned long flags;
> 
> -     daemonize("libusual_%d", type); /* "usb-storage" is kinda too long */
> -
>       /* A completion does not work here because it's counted. */
>       down(&usu_init_notify);
>       up(&usu_init_notify);
> _______________________________________________
> Usb-storage mailing list
> [EMAIL PROTECTED]
> https://lists.one-eyed-alien.net/mailman/listinfo/usb-storage

-- 
Matthew Dharm                              Home: [EMAIL PROTECTED] 
Maintainer, Linux USB Mass Storage Driver

It was a new hope.
                                        -- Dust Puppy
User Friendly, 12/25/1998

Attachment: pgp4ZqWnu7Kuo.pgp
Description: PGP signature

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Linux-usb-users@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users

Reply via email to