On Wed, 17 Oct 2007, David Miller wrote:
> From: Alan Stern <[EMAIL PROTECTED]>
> Date: Wed, 17 Oct 2007 11:51:57 -0400 (EDT)
>
> > > + break;
> > > + }
> > > + if (limit_1 < 0) {
> > > + ohci_warn(ohci, "Root port outer-loop reset timeout, "
> > > + "now[%04x] reset_done[%04x]\n",
> > > + now, reset_done);
> > > + }
> >
> > What reason is there for having two warning messages? One ought to be
> > enough.
>
> In my patch it was possible for the inner loop one to succeed, but the
> outer one to not do so.
>
> In your's this is not the case so I guess it's OK.
>
> I wonder if it's so wise trying to do two things at once. Here we are
> adding the loop timeouts, and also changing to using jiffies based
> timeouts rather than a chip timer register based one.
>
> I preferred my patches because it solved one single problem, the lack
> of loop limits. The timeout mechanism could have been changed in
> another followon patch.
At this point I'd be perfectly happy to sit back and let David B.
choose, among all the possibilities that have been posted, the one he
thinks is best.
Alan Stern
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-usb-users@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-users
