On Thu, Apr 06, 2000 at 10:18:47AM +0200, Alessandro Rubini wrote:
>
> > Note that I definitely don't like ifdef's in the middle of code, but
> > this can go at the beginning of the files.
>
> On these lines, I didn't appreciate the "#ifdef
> CONFIG_INPUT_MOUSEDEV_MIX" stuff. In my opinion the kernel should
> offer both functionality: individual mouse channels and a global
> channel.
>
> Since this is definitely policy, it shouldn't be compiled-in. Besides,
> one cannot even know what is the compiled-in default.
>
> Wouldn't it be better to have /dev/usbmice as well as /dev/usbmouse[0123]?
>
> The mousedev.o module could cleanly handle both devices. Unfortunately,
> this is an incompatible change, but fortunately few people are using the
> USB subsystem by now.
>
> Just a suggestion, though. I noticed it as a very unclean thing, in a
> package that is overall well designed.
Yes, this is a very nice idea.
--
Vojtech Pavlik
SuSE Labs
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
